Vojtech Szocs has posted comments on this change.
Change subject: userportal: fix remove multiple VMs
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java
Line 844: for (Object selectedItem : getSelectedItems()) {
Line 845: UserPortalItemModel itemModel = (UserPortalItemModel)
selectedItem;
Line 846: VM vm = itemModel.getVM();
Line 847: if (vm == null) {
Line 848: continue;
I'd rather avoid using continue and just do:
if (vm != null) {
vms.add(vm);
}
Line 849: }
Line 850:
Line 851: vms.add(vm);
Line 852: }
--
To view, visit http://gerrit.ovirt.org/16720
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I460eb5d6f0bead1df87fe9b0f221c66747cbea47
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
