Yair Zaslavsky has posted comments on this change.
Change subject: core: Adding AddExternalJobCommand command
......................................................................
Patch Set 6: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddExternalJobCommand.java
Line 32:
Line 33: @Override
Line 34: protected boolean canDoAction() {
Line 35: boolean retValue = true;
Line 36: if
(StringUtils.isEmpty(getParameters().getDescription().trim())) {
I would recommend isBlank, but not critical.
Line 37:
addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_EMPTY_DESCRIPTION);
Line 38: retValue = false;
Line 39: }
Line 40: return retValue;
--
To view, visit http://gerrit.ovirt.org/15226
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b95a094dc586e6ebbdacd44e0a034e91604386
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
