Gilad Chaplik has posted comments on this change.
Change subject: core: Add QoS to to DB and entities
......................................................................
Patch Set 6: (6 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/qos/AddNetworkQoSCommand.java
Line 21:
Line 22: @Override
Line 23: protected void executeCommand() {
Line 24: getNetworkQoS().setId(Guid.newGuid());
Line 25: getDbFacade().getQosDao().save(getNetworkQoS());
extract a method for getQosDao() in NetworkQoSCommandBase.
Line 26: getReturnValue().setActionReturnValue(getNetworkQoS().getId());
Line 27: setSucceeded(true);
Line 28: }
Line 29:
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
Line 261: AddWatchdog(1700, ActionGroup.EDIT_VM_PROPERTIES,
QuotaDependency.NONE),
Line 262: UpdateWatchdog(1701, ActionGroup.EDIT_VM_PROPERTIES,
QuotaDependency.NONE),
Line 263: RemoveWatchdog(1702, ActionGroup.EDIT_VM_PROPERTIES,
QuotaDependency.NONE),
Line 264:
Line 265: AddNetworkQoS(1800, ActionGroup.CONFIGURE_STORAGE_POOL_NETWORK,
QuotaDependency.NONE),
don't think these commands should be monitored
Line 266: UpdateNetworkQoS(1801,
ActionGroup.CONFIGURE_STORAGE_POOL_NETWORK, QuotaDependency.NONE),
Line 267: RemoveNetworkQoS(1802,
ActionGroup.CONFIGURE_STORAGE_POOL_NETWORK, QuotaDependency.NONE),
Line 268: ;
Line 269:
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/NetworkQoSDaoImpl.java
Line 9: import java.sql.ResultSet;
Line 10: import java.sql.SQLException;
Line 11: import java.util.List;
Line 12:
Line 13: public class NetworkQoSDaoImpl extends BaseDAODbFacade implements
NetworkQoSDao {
I would use DefaultGenericDaoDbFacade
Line 14:
Line 15: protected static final RowMapper<NetworkQoS> mapper =
Line 16: new RowMapper<NetworkQoS>() {
Line 17: @Override
....................................................
File backend/manager/modules/dal/src/test/resources/fixtures.xml
Line 630: <value>false</value>
Line 631: <value>pc-1.0</value>
Line 632: <value>true</value>
Line 633: </row>
Line 634: <row>
not relevant
Line 635: <value>eba797fb-8e3b-4777-b63c-92e7a5957d7d</value>
Line 636: <value>rhel6.nfs3</value>
Line 637: <null />
Line 638: <value>Intel Conroe Family</value>
....................................................
File
backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/AbstractInvertibleMappingTest.java
Line 43: mappingLocator.populate();
Line 44: }
Line 45:
Line 46: @Test
Line 47: @Ignore
remove
Line 48: public void testRoundtrip() throws Exception {
Line 49: setUpConfigExpectations();
Line 50:
Line 51: F model = fromClass.cast(populate(fromClass));
....................................................
File packaging/dbscripts/create_tables.sql
Line 1188: CONSTRAINT PK_network_qos_id PRIMARY KEY (id)
Line 1189: ) WITH OIDS;
Line 1190:
Line 1191: ALTER TABLE network_qos ADD CONSTRAINT network_qos_storage_pool_fk
Line 1192: FOREIGN KEY(storage_pool_id) REFERENCES storage_pool(id);
no cascade?
Line 1193:
Line 1194: --
----------------------------------------------------------------------
Line 1195: -- Foreign key constraints
Line 1196: --
----------------------------------------------------------------------
--
To view, visit http://gerrit.ovirt.org/16294
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If39d20b77d06165e4adcc27e6b6dc5458cac93d3
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <oma...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Eli Mesika <elimes...@gmail.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-Reviewer: ofri masad <oma...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
