Liron Ar has posted comments on this change. Change subject: core: some cleanup in ImportVmCommand ......................................................................
Patch Set 8: (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java Line 136 Line 137 Line 138 Line 139 Line 140 Arik, please return this method - in case that the VmId is explicitly set, we won't return it from getVm() which might cause to a different behaviour here...I don't think that we should handle those possible issues in a cleanup patch - meanwhile till we do a further refactor to this command, please leave it. -- To view, visit http://gerrit.ovirt.org/16296 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibfdb7bba0758cfccb55bc237f22659cb1993cc00 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
