Maor Lipchuk has posted comments on this change.
Change subject: core: revert when failing to export a template
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CopyImageGroupCommand.java
Line 191:
removeImageParams.setParentCommand(VdcActionType.RemoveImage);
Line 192:
removeImageParams.setStorageDomainId(getParameters().getStorageDomainId());
Line 193:
removeImageParams.setDbOperationScope(getParameters().getRevertDbOperationScope());
Line 194: removeImageParams.setEntityId(getDestinationImageId());
Line 195:
removeImageParams.setShouldLockImage(getParameters().getShouldLockImageOnRevert());
please disregard comment 1, removeImageParams will use true on lock by default
Line 196: // Setting the image as the monitored entity, so there
will not be dependency
Line 197: VdcReturnValueBase returnValue =
Line 198:
checkAndPerformRollbackUsingCommand(VdcActionType.RemoveImage,
removeImageParams);
Line 199: if (returnValue.getSucceeded()) {
--
To view, visit http://gerrit.ovirt.org/15781
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8d80c5d15f7321f67d54e7593cb2da1fd7186a25
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
