Allon Mureinik has posted comments on this change.
Change subject: core: handling memory snapshots on export/import vm
......................................................................
Patch Set 17: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CopyImageGroupCommand.java
Line 74: getParameters().getCopyVolumeType(),
Line 75: getParameters().getVolumeFormat(),
Line 76: getParameters().getVolumeType(),
Line 77: isWipeAfterDelete(),
Line 78: getParameters().getForceOverride(),
Lots of noise here - consider doing this in a different patch
Line 79:
getStoragePool().getcompatibility_version().toString()));
Line 80: } else {
Line 81: vdsReturnValue = runVdsCommand(
Line 82: VDSCommandType.MoveImageGroup,
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java
Line 266: }
Line 267:
Line 268: protected boolean removeMemoryVolumes(String memVols,
VdcActionType parentCommand, boolean startPollingTasks) {
Line 269: // this is temp code until it will be implemented in SPM
Line 270: List<Guid> guids = GuidUtils.getGuidListFromString(memVols);
This is a cleanup - you did not change any functionality.
Please separate it to another patch.
Line 271:
Line 272: if (guids.size() == 6) {
Line 273: // get all vm disks in order to check post zero - if one
of the
Line 274: // disks is marked with wipe_after_delete
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java
Line 513: }
Line 514: return null;
Line 515: }
Line 516:
Line 517: public static StorageDomain findStorageDomainForMemory(Guid
storagePoolId, long sizeRequested,
These two should share code somehow
Line 518: Map<StorageDomain, Integer> domain2reservedSpaceInDomain)
{
Line 519: List<StorageDomain> domainsInPool =
DbFacade.getInstance().getStorageDomainDao().getAllForStoragePool(storagePoolId);
Line 520: for (StorageDomain currDomain : domainsInPool) {
Line 521: long reservedSizeForDisks =
domain2reservedSpaceInDomain.containsKey(currDomain) ?
--
To view, visit http://gerrit.ovirt.org/15683
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifae3d5dd6bdeca04d5b5c9eee2dbe93e3eb03cea
Gerrit-PatchSet: 17
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
