Alon Bar-Lev has posted comments on this change.
Change subject: engine: Integrate SPICE-HTML5 client
......................................................................
Patch Set 3: (2 inline comments)
....................................................
File packaging/conf/ovirt-engine-proxy.conf.v2.in
Line 24: <Location /ovirt-engine/>
Line 25: ProxyPass ajp://localhost:@JBOSS_AJP_PORT@/
Line 26: </Location>
Line 27:
Line 28: <LocationMatch
^/(UserPortal($|/)|OvirtEngineWeb($|/)|webadmin($|/)|docs($|/)|ovirt-engine-novnc($|/)|ovirt-engine-novnc-main.html$|ovirt-engine-spicehtml5($|/)|ovirt-engine-spicehtml5-main.html$|spice/|ca.crt$|engine.ssh.key.txt$|rhevm.ssh.key.txt$|ovirt-engine-style.css$|ovirt-engine-attachment/)>
are you sure we need $ in ovirt-engine-spicehtml5 and ovirt-engine-novnc?
Line 29: ProxyPassMatch ajp://localhost:@JBOSS_AJP_PORT@
Line 30: <IfModule deflate_module>
Line 31: AddOutputFilterByType DEFLATE text/javascript text/css
text/html text/xml text/json application/xml application/json application/x-yaml
Line 32: </IfModule>
....................................................
File packaging/services/ovirt-websocket-proxy.py
Line 53: """
Line 54: connection_data =
self._ticketDecoder.decode(path[1:]).split(':')
Line 55: target_host = connection_data[0].encode('utf8')
Line 56: target_port = connection_data[1].encode('utf8')
Line 57: self.ssl_target = len(connection_data) >= 3 and
connection_data[2].encode('utf8') == "ssl_target"
I think we should use keyword based parameters and not position based, this way
the proxy will be able to work with different versions of engines without being
broken.
Line 58: return (target_host, target_port)
Line 59:
Line 60:
Line 61: class TicketDecoder(object):
--
To view, visit http://gerrit.ovirt.org/15257
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I490cb57f5d23a7a763807d3bee00ea0e4c032338
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
