Martin Peřina has posted comments on this change.
Change subject: core: Use VdsValidator in canDoAction of ActivateVds
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsValidator.java
Line 62: ValidationResult existsValidation = exists();
Line 63: if (!existsValidation.isValid()) {
Line 64: return existsValidation;
Line 65: }
Line 66: if (vds.getStatus().equals(VDSStatus.Up)) {
Just one minor thing: for enums I usually prefer using == instead of equals().
Nice summary about this is here:
http://stackoverflow.com/questions/1750435/comparing-java-enum-members-or-equals#answer-2937561
Line 67: return new ValidationResult(VdcBllMessages.VDS_ALREADY_UP);
Line 68: }
Line 69: return ValidationResult.VALID;
Line 70: }
--
To view, visit http://gerrit.ovirt.org/16649
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9a887de27757cd8ff89c8d68eb916be68d327fd
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Martin Peřina <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
