Sandro Bonazzola has posted comments on this change. Change subject: packaging: spec: missing dep on ovirt-host-deploy ......................................................................
Patch Set 1: (1 inline comment) .................................................... File ovirt-engine.spec.in Line 260: Requires: openssl Line 261: Requires: m2crypto Line 262: Requires: python-paramiko Line 263: Requires: otopi >= 1.1.0 Line 264: Requires: ovirt-host-deploy >= 1.1.0 no, I've verified running engine-setup-2, it's needed by engine-setup-2 also without aio plugin installed. It's cpu.py that import hardware at top level. If we want to have this dep only on aio we've to move the import inside the method. Line 265: Line 266: # We could drop these conflicts when we'll drop Requires: mod_ssl Line 267: Conflicts: ipa-server Line 268: Conflicts: freeipa-server -- To view, visit http://gerrit.ovirt.org/16614 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic9835b126611b399aaeb7fdd263bf1935a4235f5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
