Alon Bar-Lev has posted comments on this change.
Change subject: core: create_schema.sh do not support space in path
......................................................................
Patch Set 1: (4 inline comments)
....................................................
File packaging/dbscripts/dbfunctions.sh
Line 265: }
Line 266:
Line 267: is_view_or_sp_changed() {
Line 268: files=$(get_files "upgrade" 3)
Line 269: md5sum_file="${MD5DIR}"/.${DATABASE}.scripts.md5
usually, I would prefer quote all:
md5sum_file="${MD5DIR}/.${DATABASE}.scripts.md5"
Line 270: md5sum_tmp_file=${md5sum_file}.tmp
Line 271: md5sum $files create_*views.sql *_sp.sql > ${md5sum_tmp_file}
Line 272: diff -s -q ${md5sum_file} ${md5sum_tmp_file} >& /dev/null
Line 273: result=$?
Line 266
Line 267
Line 268
Line 269
Line 270
quotes
Line 268
Line 269
Line 270
Line 271
Line 272
quotes
Line 273
Line 274
Line 275
Line 276
Line 277
here too need quote...
well... you probably need to quote all.
--
To view, visit http://gerrit.ovirt.org/16608
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iad69e7a596aee50682ee0669cc8a5ffff7462e0a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
