Michael Pasternak has posted comments on this change.
Change subject: engine: add comment field to Host [3]
......................................................................
Patch Set 15: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
Line 1809: request:
Line 1810: body:
Line 1811: parameterType: Host
Line 1812: signatures:
Line 1813: - mandatoryArguments: {host.name: 'xs:string', host.comment:
'xs:string', host.address: 'xs:string', host.root_password: 'xs:string',
host.cluster.id|name: 'xs:string'}
comment is not a mandatory argument
Line 1814: optionalArguments: {host.port: 'xs:int',
host.display.address: 'xs:string', host.storage_manager.priority: 'xs:int',
host.power_management.type: 'xs:string',
Line 1815: host.power_management.enabled: 'xs:boolean',
host.power_management.address: 'xs:string', host.power_management.username:
'xs:string',
Line 1816: host.power_management.password: 'xs:string',
host.power_management.options.option--COLLECTION: {option.name: 'xs:string',
option.value: 'xs:string'}, host.power_management.pm_proxy--COLLECTION:
{propietary : 'xs:string'},
host.power_management.agents.agent--COLLECTION:{type: 'xs:string', address:
'xs:string', user_name: 'xs:string', password: 'xs:string',
options.option--COLLECTION: {option.name: 'xs:string', option.value:
'xs:string'}}, host.reboot_after_installation: 'xs:boolean'}
Line 1817: urlparams: {}
....................................................
File
backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostMapper.java
Line 217: public static Host map(VDS entity, Host template) {
Line 218: Host model = template != null ? template : new Host();
Line 219: model.setId(entity.getId().toString());
Line 220: model.setName(entity.getName());
Line 221: model.setComment(entity.getComment());
what about other direction (host->vds)?
Line 222: if (entity.getVdsGroupId() != null) {
Line 223: Cluster cluster = new Cluster();
Line 224: cluster.setId(entity.getVdsGroupId().toString());
Line 225: model.setCluster(cluster);
--
To view, visit http://gerrit.ovirt.org/15421
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I06e1bec7c4a862813b19073344f48a0ec3c17458
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Noam Slomianko <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Noam Slomianko <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
