Alon Bar-Lev has posted comments on this change. Change subject: code: host-deploy: Adding ssh_username and ssh_port to VDS object - VdsStatic fields ......................................................................
Patch Set 21: (1 inline comment) .................................................... File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java Line 827: host.setHostName(hostDetailModel.getAddress()); Line 828: host.setSshKeyFingerprint(hostDetailModel.getFingerprint()); Line 829: host.setPort(54321); Line 830: Line 831: host.setVdsGroupId(hostsModel.getClusterModel().getClusterId()); do not revert, just submit a separate patch for this and have it as a base. but better to have a complete separate patch for this over master. Line 832: host.setpm_enabled(false); Line 833: Line 834: AddVdsActionParameters parameters = new AddVdsActionParameters(); Line 835: parameters.setVdsId(host.getId()); -- To view, visit http://gerrit.ovirt.org/16096 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id2c38d23faadc4dbed65d08298e0862c5bea26dd Gerrit-PatchSet: 21 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
