Martin Peřina has posted comments on this change.
Change subject: core: host-deploy: Using ssh username and password to install
and update host
......................................................................
Patch Set 22: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java
Line 218: * tick.
Line 219: */
Line 220: private final Callable<?>[] _customizationDialog = new
Callable<?>[] {
Line 221: new Callable<Object>() { @Override
Line 222: public Object call() throws Exception {
Another Eclipse automatic change, but according to preferred code formatting we
have, this is correctly formatted code. Personally I would go even further,
place @Override to new line, indent call method more and place closing } of
Callable to the new line. But again if you insist I could revert this back.
Line 223: _parser.cliEnvironmentSet(
Line 224: "OVIRT_ENGINE/correlationId",
Line 225: _correlationId
Line 226: );
--
To view, visit http://gerrit.ovirt.org/16006
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id39914e1286870373ad6f69360fa7b3ddfabd8df
Gerrit-PatchSet: 22
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Martin Peřina <mper...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: liron aravot <liron.ara...@gmail.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
