Moran Goldboim has posted comments on this change.

Change subject: Added hook that sets the bug to MODIFIED
......................................................................


Patch Set 2: Looks good to me, but someone else must approve

(1 inline comment)

....................................................
File hooks/bz/change-merged.bz.set_MODIFIED
Line 32:     bz.login -b "$bug_id" "$bz_user" "$bz_password"
Line 33:     ### Skip downstream bugs
Line 34:     product="$(bz.get_product "$bug_id")"
Line 35:     if ! [[ "$product" =~ ^oVirt$ ]]; then
Line 36:         echo "::bug $bug_id::Not an upstream bug, current product 
$product"
i would say - "::bug $bug_id::Isn't a oVirt bug, bug belongs to $product"
Line 37:         continue
Line 38:     fi
Line 39:     ## Check if all the external bugs are closed
Line 40:     all_merged='true'


-- 
To view, visit http://gerrit.ovirt.org/15917
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifedcf594e962ab9d495bc32c48763a01890bd2a4
Gerrit-PatchSet: 2
Gerrit-Project: gerrit-admin
Gerrit-Branch: master
Gerrit-Owner: David Caro <dcaro...@redhat.com>
Gerrit-Reviewer: Eyal Edri <ee...@redhat.com>
Gerrit-Reviewer: Itamar Heim <ih...@redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com>
Gerrit-Reviewer: Ohad Basan <oba...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to