Daniel Erez has posted comments on this change.
Change subject: [wip] frontend: add the export glance image support
......................................................................
Patch Set 1: (5 inline comments)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/disks/DiskListModel.java
Line 498: }
Line 499: },
Line 500: this);
Line 501: }
Line 502:
setIsExecutionAllowed of getUploadCommand here (i.e. disable for locked
disks/LunDisks/etc)
Line 503: private void updateActionAvailability()
Line 504: {
Line 505: Disk disk = (Disk) getSelectedItem();
Line 506: ArrayList<Disk> disks = getSelectedItems() != null ?
(ArrayList<Disk>) getSelectedItems() : null;
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/ImportExportImagePopupView.java
Line 109: return ((RepoImage) image).getRepoImageTitle();
Line 110: } else if (image instanceof DiskImage) {
Line 111: return ((DiskImage) image).getDiskAlias();
Line 112: }
Line 113: return "(Unknown)"; //$NON-NLS-1$
please localize
Line 114: }
Line 115: }, constants.fileNameIso());
Line 116: imageList.addEntityModelColumn(new
EntityModelTextColumn<Object>() {
Line 117: @Override
Line 118: public String getText(Object image) {
Line 119: if (image instanceof RepoImage) {
Line 120: return ((RepoImage)
image).getFileType().toString();
Line 121: } else if (image instanceof DiskImage) {
Line 122: return "Disk"; //$NON-NLS-1$
same
Line 123: }
Line 124: return "(Unknown)"; //$NON-NLS-1$
Line 125: }
Line 126: }, constants.typeIso());
Line 120: return ((RepoImage)
image).getFileType().toString();
Line 121: } else if (image instanceof DiskImage) {
Line 122: return "Disk"; //$NON-NLS-1$
Line 123: }
Line 124: return "(Unknown)"; //$NON-NLS-1$
same
Line 125: }
Line 126: }, constants.typeIso());
Line 127: imageList.addEntityModelColumn(new
DiskSizeColumn<EntityModel>() {
Line 128: @Override
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabDiskView.java
Line 196: return getMainModel().getScanAlignmentCommand();
Line 197: }
Line 198: });
Line 199:
Line 200: getTable().addActionButton(new
WebAdminButtonDefinition<Disk>(constants.uploadDisk()) {
not sure, shouldn't we expose this command 'OnlyFromContext'?
Line 201: @Override
Line 202: protected UICommand resolveCommand() {
Line 203: return getMainModel().getUploadCommand();
Line 204: }
--
To view, visit http://gerrit.ovirt.org/16420
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If5ec1bd1de705233c3a0baf26e5f2a4c0a21645a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
