Omer Frenkel has posted comments on this change.
Change subject: core: [logging] Elaborate auto-startup of VMs
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
Line 1591: VmExitStatus.Error,
Line 1592: String.format("Could not find VM %s on host,
assuming it went down unexpectedly",
Line 1593: vmToRemove.getName()));
Line 1594: }
Line 1595:
i think we still need info here when we identify vm is down in vdsm but not in
engine (without mentioning rerun), and in the logs you added below just log
what is going to be done (rerun..)
Line 1596: vmGuid = vmToRemove.getId();
Line 1597: if (!isInMigration && !_vmsToRerun.contains(vmGuid)
Line 1598: &&
ResourceManager.getInstance().IsVmInAsyncRunningList(vmGuid)) {
Line 1599: _vmsToRerun.add(vmGuid);
--
To view, visit http://gerrit.ovirt.org/16557
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I11dcceacf3b0ed5b59421009d5d21e5422e5e77f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
