Martin Peřina has posted comments on this change.

Change subject: core: SshSoftFencingCommand.executeCommand and logging cleanup
......................................................................


Patch Set 3: (1 inline comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SshSoftFencingCommand.java
Line 65:      */
Line 66:     private boolean executeSshSoftFencingCommand(String host, String 
version) {
Line 67:         boolean result = true;
Line 68:         EngineSSHClient sshClient = null;
Line 69:         ByteArrayOutputStream bos = null;
Ok, I fixed up commit message. But PLEASE finally merge this cleanup patch and 
move along to more important work. Thanks
Line 70: 
Line 71:         try {
Line 72:             sshClient = new EngineSSHClient();
Line 73:             sshClient.setHost(host);


-- 
To view, visit http://gerrit.ovirt.org/16338
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2b65fdde5ac3f2642fb053777ef50846cb8cb8e0
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Martin Peřina <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to