Sandro Bonazzola has posted comments on this change. Change subject: packaging: setup: allow invalid fqdn in non interactive mode ......................................................................
Patch Set 1: I would prefer that you didn't submit this (2 inline comments) .................................................... Commit Message Line 11: Line 12: there are two reasons why we should not fail installation: Line 13: Line 14: 1. in upgrade we need to accept whatever host name existed during setup. Line 15: this is easy to solve by activating validation only for setup. I agree, we can assume that if the engine is working the fqdn is good enough. Line 16: Line 17: 2. user who specify host name via cmd-line should know what he is doing, Line 18: we cannot enforce our decision over. Line 19: Line 14: 1. in upgrade we need to accept whatever host name existed during setup. Line 15: this is easy to solve by activating validation only for setup. Line 16: Line 17: 2. user who specify host name via cmd-line should know what he is doing, Line 18: we cannot enforce our decision over. I agree that the user should know what he is doing, but he may just insert a typo when he's specifying the fqdn and we'll accept the fqdn anyway. I think that on fresh installs we should check the fqdn. If we really want to allow to skip the fqdn validation, we can add a variable for disabling the check. Line 19: Line 20: this change will produce error during non interactive setup, but will Line 21: allow setup to continue. Line 22: -- To view, visit http://gerrit.ovirt.org/16543 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic6c80ac47d55ade01dd6a3472e950d2c0ffa0074 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
