Moti Asayag has posted comments on this change.
Change subject: core: Adding GetMonitoredCommandsQuery
......................................................................
Patch Set 6: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetMonitoredCommandsQuery.java
Line 13: }
Line 14:
Line 15: @Override
Line 16: protected void executeQueryCommand() {
Line 17: List<String> result = new ArrayList<String>();
The result of the query is the same and will be modified only between version.
Wouldn't it be enough to cache it ?
Line 18: for (VdcActionType actionType : VdcActionType.values()) {
Line 19: if (actionType.isActionMonitored()) {
Line 20: result.add(actionType.name());
Line 21: }
--
To view, visit http://gerrit.ovirt.org/15231
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9ce0d9ddc2bf93c43e0ec55c88e17a9f79eed80
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
