Daniel Erez has posted comments on this change. Change subject: frontend: in some cases the display options are not taken from template ......................................................................
Patch Set 2: Looks good to me, approved (3 inline comments) .................................................... Commit Message Line 5: CommitDate: 2013-07-04 15:13:48 +0200 Line 6: Line 7: frontend: in some cases the display options are not taken from template Line 8: Line 9: The problem was that firt the options depending on the display s/firt/first Line 10: protocol has been copied from template to VM and than the display Line 11: type. It could happen, that you had a display protocol e.g. VLC Line 12: and than you have selected something which makes sense only for Line 13: SPICE, than this options has been ignored. Line 6: Line 7: frontend: in some cases the display options are not taken from template Line 8: Line 9: The problem was that firt the options depending on the display Line 10: protocol has been copied from template to VM and than the display s/than/then Line 11: type. It could happen, that you had a display protocol e.g. VLC Line 12: and than you have selected something which makes sense only for Line 13: SPICE, than this options has been ignored. Line 14: Line 9: The problem was that firt the options depending on the display Line 10: protocol has been copied from template to VM and than the display Line 11: type. It could happen, that you had a display protocol e.g. VLC Line 12: and than you have selected something which makes sense only for Line 13: SPICE, than this options has been ignored. s/has/have Line 14: Line 15: Fixed by moving the relevant options under the display protocol Line 16: setting. Line 17: -- To view, visit http://gerrit.ovirt.org/16450 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I77a995eff3e800ba000cc3049eb1929d30ee91e8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
