Alex Lourie has uploaded a new change for review.

Change subject: packaging: setup: Removed unnecessary DB defaults
......................................................................

packaging: setup: Removed unnecessary DB defaults

Currently common.sh defines /root/.pgpass file as default
value. This overrides the value provided by the setup and in
some cases causes incorrect password to be supplied to the DB
utilities.

The new approach removes the default value as pgpass file is
generated on the fly in temporary location, and it is being
appended to the running environment dynamically.

Change-Id: Ib20a80aff04ac5f977b55ee9a5e71607292ea8ff
Signed-off-by: Alex Lourie <alou...@redhat.com>
---
M backend/manager/tools/dbutils/common.sh
1 file changed, 0 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/69/16469/1

diff --git a/backend/manager/tools/dbutils/common.sh 
b/backend/manager/tools/dbutils/common.sh
index 4205bbe..7ec60c8 100755
--- a/backend/manager/tools/dbutils/common.sh
+++ b/backend/manager/tools/dbutils/common.sh
@@ -8,15 +8,5 @@
     USERNAME="engine"
     VERBOSE=false
     LOGFILE="$ME.log"
-
-    # When running in development environments the .pgpass file may not
-    # exist or might not be readable, so we should try to use the file
-    # stored in the home directory of the user instead:
-    PGPASSFILE="/etc/ovirt-engine/.pgpass"
-    if [ ! -r "${PGPASSFILE}" ]
-    then
-        PGPASSFILE="${HOME}/.pgpass"
-    fi
-    export PGPASSFILE
 }
 


-- 
To view, visit http://gerrit.ovirt.org/16469
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib20a80aff04ac5f977b55ee9a5e71607292ea8ff
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <alou...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to