Eli Mesika has posted comments on this change.

Change subject: core: Adding ClearExternalJobCommand
......................................................................


Patch Set 4: (2 inline comments)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ClearExternalJobCommand.java
Line 22: 
Line 23:     @Override
Line 24:     protected boolean canDoAction() {
Line 25:         boolean retValue = true;
Line 26:         if (getParameters().getJobId() != null) {
OK
Line 27:             job = getJobDao().get((Guid) getParameters().getJobId());
Line 28:             if (job == null) {
Line 29:                 retValue = false;
Line 30:                 
addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_NOT_EXTERNAL);


Line 22: 
Line 23:     @Override
Line 24:     protected boolean canDoAction() {
Line 25:         boolean retValue = true;
Line 26:         if (getParameters().getJobId() != null) {
OK
Line 27:             job = getJobDao().get((Guid) getParameters().getJobId());
Line 28:             if (job == null) {
Line 29:                 retValue = false;
Line 30:                 
addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_NOT_EXTERNAL);


-- 
To view, visit http://gerrit.ovirt.org/15230
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b95a094dc586e6ebbdacd44e0a034e91605498
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to