Daniel Erez has posted comments on this change. Change subject: webadmin: Fixed display of changeability prohibition reasons ......................................................................
Patch Set 1: Looks good to me, but someone else must approve It's actually not necessary in this case since we ensure in the visit method (UiCommonEditorVisitor) that 'onIsChangablePropertyChange' is invoked. [1] However, for consistency, we should indeed proceed with this change. [1] // Update editor since we might have missed property change // events fired as part of the entity model constructor onIsValidPropertyChange(functionalEditor, ownerModel); onIsChangablePropertyChange(functionalEditor, ownerModel); onIsAvailablePropertyChange(functionalEditor, ownerModel); -- To view, visit http://gerrit.ovirt.org/16463 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I685595a685e0ba4ff98f73002dda13085fc04f46 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
