Allon Mureinik has posted comments on this change.
Change subject: core: Use UUID in createGuidMapper()
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/BaseDAODbFacade.java
Line 57: return new RowMapper<Guid>() {
Line 58:
Line 59: @Override
Line 60: public Guid mapRow(ResultSet rs, int rowNum) throws
SQLException {
Line 61: return new Guid((UUID) rs.getObject(1));
1. This is not declared in JDBC2, but any database I saw does work this way.
2.
A. You are right, but it's on their roadmap to fix once they drop some older
JVM support
B. I want to align it with the UUID settObject we use
Line 62: }
Line 63: };
Line 64: }
Line 65:
--
To view, visit http://gerrit.ovirt.org/16430
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I426b829e4699e344af587a3bfaacb8782ab8cbe0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
