Maor Lipchuk has posted comments on this change.
Change subject: core : fix of diskless vm import
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
Line 532: @Override
Line 533: protected void executeCommand() {
Line 534: try {
Line 535: addVmToDb();
Line 536: VM vm = getVm();
You removed the vm.getImages() with the tasks check so you should also remove
the vm variable since no one is using it
Line 537: processImages();
Line 538: // if there aren't tasks - we can just perform the end
Line 539: // vm related ops
Line 540: if (getReturnValue().getTaskIdList().isEmpty()) {
--
To view, visit http://gerrit.ovirt.org/16449
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If2d53edfb828de11d6106001a4f9ab7020da4bdd
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
