Martin Peřina has posted comments on this change.
Change subject: core: SshSoftFencingCommand.executeCommand cleanup
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SshSoftFencingCommand.java
Line 27: * If the VDS is not responding, it executes SSH Soft Fencing.
Line 28: */
Line 29: @Override
Line 30: protected void executeCommand() {
Line 31: boolean result = true;
Well, it could worked for code on line 40, but not for 58. So I moved result
variable result to if section, where it is used.
Line 32: VdsValidator validator;
Line 33:
Line 34: setVds(null);
Line 35: if (getVds() == null) {
--
To view, visit http://gerrit.ovirt.org/16338
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2b65fdde5ac3f2642fb053777ef50846cb8cb8e0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Martin Peřina <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
