Yaniv Bronhaim has posted comments on this change. Change subject: Adding ssh_username and ssh_port to VDS object - VdsStatic fields ......................................................................
Patch Set 15: (2 inline comments) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterVdsQuery.java Line 307: Line 308: // For new registration use default ssh port and user 'root' Line 309: final int SSH_PORT = 22; Line 310: final String SSH_USER_NAME = "root"; Line 311: could be .. but lets delay it to next patch, because we already do that in ugly way all over the code. I need a patch only for removing all those constants definistions Line 312: VdsStatic vds = new VdsStatic(getParameters().getVdsHostName(), "", Line 313: getStrippedVdsUniqueId(), getParameters().getPort(), Line 314: SSH_PORT, Line 315: SSH_USER_NAME, .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java Line 104: && ObjectUtils.objectsEqual(vdsGroupGlusterService, other.vdsGroupGlusterService)); Line 105: } Line 106: Line 107: public VDS(Guid vds_group_id, String vds_group_name, String vds_group_description, Guid vds_id, String vds_name, Line 108: String ip, String host_name, int port, int ssh_port, String ssh_username, int status, Integer cpu_cores, Integer cpuThreads, String cpu_model, all attributes here are that way, so i keep the same standard Line 109: String hwManufacturer, String hwProductName, Line 110: String hwVersion, String hwSerialNumber, String hwUUID, String hwFamily, Line 111: Double cpu_speed_mh, String if_total_speed, Boolean kvm_enabled, Integer physical_mem_mb, Line 112: Double cpu_idle, Double cpu_load, Double cpu_sys, -- To view, visit http://gerrit.ovirt.org/16096 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id2c38d23faadc4dbed65d08298e0862c5bea26dd Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
