Lior Vernia has posted comments on this change.
Change subject: webadmin: Added sorting infrastructure to SearchableListModel
......................................................................
Patch Set 5: (2 inline comments)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SearchableListModel.java
Line 648: return;
Line 649: }
Line 650: Iterable identicalItems = (comparator == null) ? new
ArrayList() : new TreeSet(comparator);
Line 651: for (Object item : items) {
Line 652: setItems(identicalItems);
You are correct of course, clearly an error.
Line 653: }
Line 654: }
Line 655:
Line 656: @Override
Line 674: lastSelectedItems.add((IVdcQueryable) item);
Line 675: }
Line 676: }
Line 677:
Line 678: if (comparator == null || value instanceof SortedSet) {
Very good catch! Fixed for it to check if it's the same comparator as well,
also in setComparator().
Line 679: itemsChanging(value, items);
Line 680: items = value;
Line 681: } else {
Line 682: TreeSet sortedValue = null;
--
To view, visit http://gerrit.ovirt.org/15846
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idadafcb33979d85b7ca332cad717b7c1ceadec4b
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
