Federico Simoncelli has posted comments on this change.
Change subject: [wip] backend: add the export glance image support
......................................................................
Patch Set 1: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportRepoImageCommand.java
Line 64: }
Line 65:
Line 66:
getParameters().setParentCommand(VdcActionType.ExportRepoImage);
Line 67:
Line 68: Guid taskId = getAsyncTaskId();//
persistAsyncTaskPlaceHolder(getParameters().getParentCommand());
Unsure, related to the comment below.
Line 69: getParameters().setEntityInfo(new
EntityInfo(VdcObjectType.Disk, getParameters().getImageGroupID()));
Line 70:
Line 71: VDSReturnValue vdsReturnValue = runVdsCommand(
Line 72: VDSCommandType.UploadImage, new
UploadImageVDSCommandParameters(
Line 76: getParameters().getImageId(),
Line 77: new
HttpLocationInfo(proxy.getImageUrl(newImageId), headers)
Line 78: ));
Line 79:
Line 80: if (vdsReturnValue.getSucceeded()) {
Some confusion here. I think a rebase broke the execution of this task (polling
not starting).
Line 81: getReturnValue().getInternalVdsmTaskIdList().add(
Line 82: createTask(taskId,
Line 83: vdsReturnValue.getCreationInfo(),
Line 84: getParameters().getParentCommand(),
Line 125: return diskImage;
Line 126: }
Line 127:
Line 128: @Override
Line 129: protected boolean canDoAction() {
Obviously missing implementation.
Line 130: return true;
Line 131: }
--
To view, visit http://gerrit.ovirt.org/16419
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id93d40ebb812e4be8669ad14f6ba92aab4de28ac
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
