Tomas Jelinek has posted comments on this change.
Change subject: frontend: Make adding (virtio-)console to virtual machines
optional
......................................................................
Patch Set 6: (2 inline comments)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java
Line 189: }
Line 190: }
Line 191: }));
Line 192:
Line 193: Frontend.RunQuery(VdcQueryType.GetConsoleDevices, new
IdQueryParameters(getVm().getId()), new AsyncQuery(this, new
INewAsyncCallback() {
This is copy-pasted couple of times - please extract it to some method like
"updateVirtioConsoleEnabled" or something like this to a higher class.
Line 194: @Override
Line 195: public void onSuccess(Object model, Object returnValue) {
Line 196: List<String> consoleDevices = (List<String>)
((VdcQueryReturnValue)returnValue).getReturnValue();
Line 197:
getModel().getIsConsoleDeviceEnabled().setEntity(!consoleDevices.isEmpty());
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmModelBehavior.java
Line 231: initStorageDomains();
Line 232: }
Line 233:
Line 234: @Override
Line 235: public void oSType_SelectedItemChanged() {
Why only on new VM? Don't you need this also on the rest of the places like
edit vm, new/edit pool, template etc?
Line 236: if (getModel().getOSType().getSelectedItem() == null) {
Line 237: return;
Line 238: }
Line 239:
--
To view, visit http://gerrit.ovirt.org/15613
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf5f82b56940dbb43fe40f45a2a90eb004f29f4d
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <fkob...@redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com>
Gerrit-Reviewer: Itamar Heim <ih...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
