Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: log setup events - add otopi upgrade ......................................................................
Patch Set 3: (1 inline comment) .................................................... File packaging/setup/plugins/ovirt-engine-common/distro-rpm/log_setup_event.py Line 65: osetupcons.Const.ACTION_UPGRADE): Line 66: if self.environment[osetupcons.CoreEnv.UPGRADE_FROM_LEGACY]: Line 67: extra = ' (from monolithic setup)' Line 68: else: Line 69: extra = ' (from otopi setup)' If you refer to PACKAGE_VERSION = '3.3.0_master', this does not help to identify whether the user ran 'engine-setup' or 'engine-setup-2'. Line 70: self.execute( Line 71: ( Line 72: osetupcons.FileLocations.OVIRT_ENGINE_LOG_SETUP_EVENT, Line 73: '--notes=Start of otopi action %s%s' % ( -- To view, visit http://gerrit.ovirt.org/16245 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0805134c602f37a646065a8794feb3721587d601 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Lev Veyde <lve...@gmail.com> Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
