Liran Zelkha has posted comments on this change.
Change subject: tools: Add script to dump heap
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File packaging/bin/engine-heap-dump.sh
Line 29: echo "Histogram file created"
Line 30:
Line 31: # Dump the heap:
Line 32: su - "${ENGINE_USER}" -s /bin/sh -c "${JMAP}
-dump:format=b,file=${DUMP} ${PID}"
Line 33:
I would like to add a ${JMAP} -heap here, so we can see the summary of the heap
behavior over time.
Line 34: # Bye:
--
To view, visit http://gerrit.ovirt.org/15359
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ea3355eafbb07d2b6c9594abcc282c139d2f31f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Liran Zelkha <liran.zel...@gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
