Allon Mureinik has posted comments on this change. Change subject: core: organize RemoveDiskCommand#getSharedLocks() ......................................................................
Patch Set 6: Looks good to me, approved (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java Line 361: case VM: Line 362: return createSharedLocksForVmDisk(); Line 363: case TEMPLATE: Line 364: return createSharedLocksForTemplateDisk(); Line 365: default: probably not a bad idea to log an error here too Line 366: return null; Line 367: } Line 368: } Line 369: -- To view, visit http://gerrit.ovirt.org/15878 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If116452d24f838a9459ee97c88e7e49d13d0de3e Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
