Eli Mesika has posted comments on this change.
Change subject: [WIP] : [db] create application objects within own schema
......................................................................
Patch Set 5: (3 inline comments)
....................................................
File backend/manager/dbscripts/upgrade/03_03_0160_set_ovirt_schema.sh
Line 17: CMD="select 'alter sequence ' || relname || ' set schema
ovirt_engine;' from pg_statio_user_sequences where schemaname !=
'ovirt_engine';"
Line 18: execute_command "${CMD}" "${DATABASE}" ${SERVERNAME} ${PORT} >> $file
Line 19:
Line 20: psql -U ${USERNAME} -h ${SERVERNAME} -p ${PORT} -f $file ${DATABASE} >
/dev/null
Line 21:
upgrade scripts can be sql based or shell based , both are supported, there is
nothing wrong in implementing something in shell rather than SQL
Line 22:
....................................................
File
backend/manager/dbscripts/upgrade/post_upgrade/0010_add_object_column_white_list_table.sql
Line 33: -- vds view
Line 34: -----------------------------------
Line 35: -- A new added column will not be displayed for the user unless
added specifically.
Line 36: insert into object_column_white_list(object_name,column_name)
Line 37: (select distinct 'vds', column_name
In will introduce it as a PRE patch and turn this patch to a patch sequence
Line 38: from information_schema.columns
Line 39: where table_name = 'vds' and
Line 40: column_name in (
Line 41: 'vds_group_id', 'vds_group_name', 'vds_group_description',
'selection_algorithm',
....................................................
File backend/manager/dbscripts/upgrade/pre_upgrade/0001_set_schema.sql
Line 4: BEGIN
Line 5: IF NOT EXISTS (select 1 from pg_catalog.pg_namespace where nspname
= 'ovirt_engine') THEN
Line 6: CREATE SCHEMA ovirt_engine;
Line 7: -- Grant permission on the new schema to user engine
Line 8: GRANT ALL ON SCHEMA ovirt_engine TO engine;
The development environment will be handled by Alon B L to set that correctly
after this patch is merged
Line 9: END IF;
Line 10: END; $procedure$
Line 11: LANGUAGE plpgsql;
Line 12: SELECT __temp_set_schema();
--
To view, visit http://gerrit.ovirt.org/14978
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic1801ce852e7637523314d57b34cdfaa58f425b1
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alexey Chub <ac...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
