Alon Bar-Lev has posted comments on this change. Change subject: [WIP] packaging: added DB validation functions ......................................................................
Patch Set 6: (1 inline comment) .................................................... File packaging/setup/ovirt_engine_setup/constants.py Line 126: Line 127: OVIRT_ENGINE_DB_UTILS_DIR = os.path.join( Line 128: OVIRT_ENGINE_DATADIR, Line 129: 'scripts', Line 130: 'dbutils' please move this to ovirt-engine/setup/dbutils, update the legacy setup as well, this way we will be able to remove this scripts dir and the legacy setup without changing this code. Line 131: ) Line 132: OVIRT_ENGINE_DB_VALIDATOR = os.path.join( Line 133: OVIRT_ENGINE_DB_UTILS_DIR, Line 134: 'validatedb.sh' -- To view, visit http://gerrit.ovirt.org/15970 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I25979acbf54d980168be929638ff4aed800bf6d3 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
