Omer Frenkel has posted comments on this change.
Change subject: backend: Make adding (virtio-)console to virtual machines
optional
......................................................................
Patch Set 4: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
Line 331: && vmFromParams.getMigrationSupport() ==
MigrationSupport.MIGRATABLE) {
Line 332: return
failCanDoAction(VdcBllMessages.VM_HOSTCPU_MUST_BE_PINNED_TO_HOST);
Line 333: }
Line 334:
Line 335: if (getParameters().isConsoleEnabled() != null &&
getVm().isRunning() && consoleDeviceChanged()) {
paused and suspended are also problematic, maybe better to use isDown() ?
Line 336: return
failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_VM_IS_RUNNING);
Line 337: }
Line 338:
Line 339: return true;
Line 340: }
Line 341:
Line 342: private boolean consoleDeviceChanged() {
Line 343: List<VmDevice> consoleDevices =
getVmDeviceDao().getVmDeviceByVmIdTypeAndDevice(getParameters().getVmId(),
Line 344: VmDeviceGeneralType.CONSOLE,
VmDeviceType.CONSOLE.getName());
why not use getVmDeviceByVmIdAndType ?
Line 345:
Line 346: return getParameters().isConsoleEnabled() ==
consoleDevices.isEmpty();
Line 347: }
Line 348:
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
Line 334: }
Line 335: }
Line 336: }
Line 337:
Line 338: if (isConsoleEnabled && !hasAlreadyConsoleDevice) {
what happens if isConsoleEnabled==false and hasAlreadyConsoleDevice==true ?
(for example add vm from template, where template has console device but user
sent false in the parameter)
Line 339: addConsoleDevice(dstId);
Line 340: }
Line 341:
Line 342: if (isVm) {
--
To view, visit http://gerrit.ovirt.org/15554
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5d913b1fca9d064424aab58d4c34ec3e4b246373
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <fkob...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
