Yair Zaslavsky has posted comments on this change.
Change subject: core: Adding AddExternalStepCommand
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddExternalStepCommand.java
Line 48: if (job == null && parentStep == null) {
Line 49: retValue=false;
Line 50:
addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_NO_PARENT);
Line 51: }
Line 52: if (getParameters().getDescription().trim().length() == 0) {
Disregard my question about StringUtils.isEmpty in previous patch.
But worth adding a null check (here and in the patch of AddExternalJob)
Line 53: retValue=false;
Line 54:
addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_EMPTY_DESCRIPTION);
Line 55: }
Line 56: if (!retValue) {
--
To view, visit http://gerrit.ovirt.org/15227
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I014a4911873ebe7c8dc37b6504655b377d73da3e
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
