Kanagaraj M has posted comments on this change.
Change subject: gluster:Support Striped_replicate volume types
......................................................................
Patch Set 6: (3 inline comments)
Changes to Enums.properties and AppErrors.properties is missing.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/AddBricksToGlusterVolumeCommand.java
Line 163: && getParameters().getReplicaCount() >
getGlusterVolume().getReplicaCount()) {
Line 164: return true;
Line 165: } else {
Line 166: return false;
Line 167: }
this can be more simple as
getGlusterVolume().getVolumeType().isReplicatedType()
&& getParameters().getReplicaCount() > getGlusterVolume().getReplicaCount()
Line 168: }
Line 169:
Line 170: private boolean isStripeCountIncreased() {
Line 171: if ((getGlusterVolume().getVolumeType().isStripedType())
Line 172: && getParameters().getStripeCount() >
getGlusterVolume().getStripeCount()) {
Line 173: return true;
Line 174: } else {
Line 175: return false;
Line 176: }
same as above
Line 177: }
Line 178:
Line 179: private GlusterStatus getBrickStatus() {
Line 180: return getGlusterVolume().getStatus();
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickListModel.java
Line 581: int replicaCount = removeBrickModel.getReplicaCount();
Line 582:
Line 583: if (selectedBricks.size() != stripeCount * replicaCount) {
Line 584: return false;
Line 585: }
is it possible to remove multiple distribution groups in a single shot?
If yes, then there is problem with the above logic.
Line 586:
Line 587: return true;
Line 588: }
Line 589:
--
To view, visit http://gerrit.ovirt.org/15381
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I517c1e9e41f1bb68626d5a8a45d679208934d98f
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
