Alon Bar-Lev has posted comments on this change.
Change subject: Using ssh username and password to install and update host
......................................................................
Patch Set 3: (3 inline comments)
one thing I did not understand is why do you still hardcode root at many places.
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostResource.java
Line 324: @Override
Line 325: public VdcActionParametersBase getParameters(Host incoming,
VDS entity) {
Line 326: VdsStatic updated = getMapper(modelType,
VdsStatic.class).map(incoming,
Line 327: entity.getStaticData());
Line 328: UpdateVdsActionParameters updateParams = new
UpdateVdsActionParameters(updated, "root", "", false);
why hardcode?
Line 329: if (incoming.isSetOverrideIptables()) {
Line 330:
updateParams.setOverrideFirewall(incoming.isOverrideIptables());
Line 331: }
Line 332: return updateParams;
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGeneralModel.java
Line 496: AddVdsActionParameters parameters = new
AddVdsActionParameters();
Line 497: parameters.setVdsId(host.getId());
Line 498: parameters.setvds(host);
Line 499: parameters.setPassword(hostDetailModel.getPassword());
Line 500: parameters.setUsername("root"); //$NON-NLS-1$
why hardcode?
Line 501: parameters.setOverrideFirewall(false);
Line 502:
parameters.setRebootAfterInstallation(getEntity().supportsVirtService());
Line 503: parametersList.add(parameters);
Line 504: }
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGuideModel.java
Line 493: AddVdsActionParameters vdsActionParams = new
AddVdsActionParameters();
Line 494: vdsActionParams.setvds(host);
Line 495: vdsActionParams.setVdsId(host.getId());
Line 496: vdsActionParams.setPassword((String)
model.getRootPassword().getEntity());
Line 497: vdsActionParams.setUsername("root"); //$NON-NLS-1$
same here, why hardcode?
Line 498: vdsActionParams.setRebootAfterInstallation(((VDSGroup)
model.getCluster().getSelectedItem()).supportsVirtService());
Line 499:
Line 500: model.startProgress(null);
Line 501:
--
To view, visit http://gerrit.ovirt.org/16006
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id39914e1286870373ad6f69360fa7b3ddfabd8df
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
