Alon Bar-Lev has posted comments on this change.
Change subject: engine: Integrate SPICE-HTML5 client
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File packaging/services/ovirt-websocket-proxy.py
Line 53: """
Line 54: connection_data =
self._ticketDecoder.decode(path[1:]).split(':')
Line 55: target_host = connection_data[0].encode('utf8')
Line 56: target_port = connection_data[1].encode('utf8')
Line 57: self.ssl_target = len(connection_data) >= 3 and
connection_data[2].encode('utf8') == "ssl_target"
I suggest you move to json notation or similar, instead of positional.
We also need to configure CA certificate to validate peer certificate.
Line 58: return (target_host, target_port)
Line 59:
Line 60:
Line 61: class TicketDecoder(object):
--
To view, visit http://gerrit.ovirt.org/15257
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I490cb57f5d23a7a763807d3bee00ea0e4c032338
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <fkob...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com>
Gerrit-Reviewer: Itamar Heim <ih...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
