Itamar Heim has posted comments on this change. Change subject: userportal,webadmin: unify new server/desktop to newVm ......................................................................
Patch Set 9: (3 inline comments) .................................................... Commit Message Line 19: - provisioning: thin for desktop, clone for server Line 20: Line 21: This defaults can be overridden. Line 22: Line 23: A new checkbox has been introduced to the System tab for the VM: Console tab sounds more appropriate than System tab? Line 24: Soundcard enabled (previously this has been determined by vm type, Line 25: now it has to be explicitly set). Line 26: Line 27: If new vm is pressed, the default settins are server. Line 25: now it has to be explicitly set). Line 26: Line 27: If new vm is pressed, the default settins are server. Line 28: Line 29: For new pool the the default is desktop and can not be changed. didn't understand this - the default 'recommended for' is desktop, type will remain desktop? admin can override all properties as usual other than that? Line 30: Line 31: After the VM is created, the vm type can not be changed. Line 32: Line 33: Change-Id: Ibcb7065e2968a84fef30951e8a45019ea1095520 Line 27: If new vm is pressed, the default settins are server. Line 28: Line 29: For new pool the the default is desktop and can not be changed. Line 30: Line 31: After the VM is created, the vm type can not be changed. other than backward compatibility, any reason we keep it? do we make any use of it? Line 32: Line 33: Change-Id: Ibcb7065e2968a84fef30951e8a45019ea1095520 -- To view, visit http://gerrit.ovirt.org/15048 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibcb7065e2968a84fef30951e8a45019ea1095520 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
