Arik Hadas has posted comments on this change.
Change subject: webadmin: add memory option to create snapshot popup
......................................................................
Patch Set 6: (1 inline comment)
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmSnapshotCreatePopupWidget.java
Line 81: updateMemoryBoxVisibility();
Line 82: }
Line 83: }
Line 84:
Line 85: private void updateMemoryBoxVisibility() {
if it was just extracting this method I would do so now, but the method would
then need to get the model as parameter which is less nice.. of course it would
be better to extract it over duplicate the code - so let's do it when we'll
need this logic outside of the inner class
Line 86: VM vm = model.getVm();
Line 87: if (vm == null) {
Line 88: return;
Line 89: }
--
To view, visit http://gerrit.ovirt.org/15685
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab771d2f9ae18e7812fe8ee9806a65cbb6576a21
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
