Frank Kobzik has posted comments on this change. Change subject: packaging: setup: add websocket proxy configuration ......................................................................
Patch Set 1: Verified Thank you for the patch, I've checked it with engine-setup and it works nice. I have only one concern: The default value of the websocket address should contain also port (e.g. 'Engine:6100'). In initial versions of noVNC integration specifying 'Engine' worked, but it relied on hardcoded port in the engine, which was not nice. -- To view, visit http://gerrit.ovirt.org/16014 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5d5fad4dc61d9c89c4165a74e9922eded483beac Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
