Michael Pasternak has posted comments on this change.
Change subject: restapi: Remove Mockito from Tests
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File
backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/AbstractInvertibleMappingTest.java
Line 42: public void setUp() {
Line 43: mappingLocator = new MappingLocator();
Line 44: mappingLocator.populate();
Line 45: HashMap<Integer, String> osNames = new HashMap<>(1);
Line 46: osNames.put(0, "Unassigned");
why osNames have to be in abstract class? override this method where is needed
and add it there
Line 47: }
Line 48:
Line 49: @Test
Line 50: public void testRoundtrip() throws Exception {
--
To view, visit http://gerrit.ovirt.org/16040
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I14d5e772de6b79ae88ed2cfabdd873461e3b5d71
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ori Liel <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
