Daniel Erez has posted comments on this change.
Change subject: webadmin: add memory column to snapshot subtab
......................................................................
Patch Set 6: (2 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java
Line 91: SupportCustomDeviceProperties(ConfigAuthType.User),
Line 92: CustomDeviceProperties(ConfigAuthType.User),
Line 93: MultipleGatewaysSupported,
Line 94: VirtIoScsiEnabled(ConfigAuthType.User),
Line 95: MemorySnapshotSupported
Isn't it supported in the UserPortal?
Line 96: ;
Line 97:
Line 98: public static enum ConfigAuthType {
Line 99: Admin,
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmSnapshotListModelTable.java
Line 106: if (vm == null) {
Line 107: return;
Line 108: }
Line 109:
Line 110:
getTable().ensureColumnPresent(SnapshotsViewColumns.dateColumn,
Shouldn't 'SnapshotsViewColumns' class be included in this patch?
Line 111: constants.dateSnapshot(), true, "150px");
//$NON-NLS-1$
Line 112:
Line 113:
getTable().ensureColumnPresent(SnapshotsViewColumns.statusColumn,
Line 114: constants.statusSnapshot(), true, "75px");
//$NON-NLS-1$
--
To view, visit http://gerrit.ovirt.org/15684
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9a5159f84fff98377526da336759445e41068f3
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
