Yair Zaslavsky has posted comments on this change.

Change subject: gluster:VDS command to get gluster tasks list
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File 
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterTasksListReturnForXmlRpc.java
Line 29: 
Line 30:     }
Line 31: 
Line 32:     private GlusterAsyncTask getTask(Map<String, Object> map) {
Line 33:         GlusterAsyncTask task = new GlusterAsyncTask();
what are you doing with the map variable?
If this is still "work in progress" please define it in the title of the patch.
Line 34:         return task;
Line 35:     }
Line 36: 
Line 37:     public List<GlusterAsyncTask> getGlusterTasks() {


-- 
To view, visit http://gerrit.ovirt.org/15972
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3bf9c1075cd7b27adcbbff8d71de183f40a02eea
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to