Alon Bar-Lev has posted comments on this change. Change subject: utils: introduce EngineSSHClient wrapper ......................................................................
Patch Set 1: > If we want to enforce the fingerprint validation in each engine's connect, > why not to have override of connect in EngineSSHClient that gets fingerprint > to compare and does that? otherwise we'll repeat the same condition before > all EngineSSHClient.connect But this is what I wrote... to allow you exactly that. -- To view, visit http://gerrit.ovirt.org/15969 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1993ac7e01963135aa8f53ce481b308b6531ecd3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
