Vojtech Szocs has posted comments on this change. Change subject: userportal,webadmin: Customized parameterized messages ......................................................................
Patch Set 4: Looks good to me, approved (2 inline comments) Overall, patch looks good. .................................................... File frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/AboutPopupView.ui.xml Line 2: <!DOCTYPE ui:UiBinder SYSTEM "http://dl.google.com/gwt/DTD/xhtml.ent";> Line 3: <ui:UiBinder xmlns:ui="urn:ui:com.google.gwt.uibinder" xmlns:g="urn:import:com.google.gwt.user.client.ui" Line 4: xmlns:d="urn:import:org.ovirt.engine.ui.common.widget.dialog"> Line 5: Line 6: <ui:with field='dynamicMessages' type='org.ovirt.engine.ui.userportal.ApplicationDynamicMessages' /> I guess we don't need this <ui:with> stuff anymore. Line 7: Line 8: <ui:style> Line 9: .content { Line 10: } .................................................... File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/AboutPopupView.ui.xml Line 2: <!DOCTYPE ui:UiBinder SYSTEM "http://dl.google.com/gwt/DTD/xhtml.ent";> Line 3: <ui:UiBinder xmlns:ui="urn:ui:com.google.gwt.uibinder" xmlns:g="urn:import:com.google.gwt.user.client.ui" Line 4: xmlns:d="urn:import:org.ovirt.engine.ui.common.widget.dialog"> Line 5: Line 6: <ui:with field='dynamicMessages' type='org.ovirt.engine.ui.webadmin.ApplicationDynamicMessages' /> I guess we don't need this <ui:with> stuff anymore. Line 7: Line 8: <ui:style> Line 9: .content { Line 10: } -- To view, visit http://gerrit.ovirt.org/15838 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iad253128d6bb48b0be93bb580803101b7e85bcea Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
