Sandro Bonazzola has posted comments on this change.

Change subject: packaging: setup: allow upgrade with 3.0 compatibility level
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File packaging/setup/plugins/ovirt-engine-common/core/misc.py
Line 69:             None
Line 70:         )
Line 71:         self.environment.setdefault(
Line 72:             osetupcons.CoreEnv.UPGRADE_SUPPORTED_VERSIONS,
Line 73:             '3.0,3.1,3.2,3.3'
the context here is cluster/dc versions, maybe we can use a more significant 
name here
Line 74:         )
Line 75: 
Line 76:         if self.environment[osetupcons.CoreEnv.DEVELOPER_MODE] is None:
Line 77:             self.environment[osetupcons.CoreEnv.DEVELOPER_MODE] = False


-- 
To view, visit http://gerrit.ovirt.org/15973
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5d61318d35c6308e41c78577029a944f061f72c4
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Itamar Heim <ih...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to