Shahar Havivi has posted comments on this change.
Change subject: frontend,engine: inherit template permissions on VM creation
......................................................................
Patch Set 1: (1 inline comment)
Tomas,
You need to add Api support as well as the UI support
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommand.java
Line 92: }
Line 93:
Line 94: PermissionDAO dao = getDbFacade().getPermissionDao();
Line 95:
Line 96: List<permissions> templatePermissions =
dao.getAllForEntity(getVmTemplateId(), getCurrentUser().getUserId(), false);
You need to filter out the PredefinedRoles.TEMPLATE_OWNER and
PredefinedRoles.TEMPLATE_USER permissions
Line 97:
Line 98: List<permissions> vmPermissions = new ArrayList<permissions>();
Line 99:
Line 100: for (permissions templatePermission : templatePermissions) {
--
To view, visit http://gerrit.ovirt.org/15667
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e6fddcea410ab8fee5851468980b8eeb0dad428
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Martin Beták <mbe...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
